From b9fcd0c14a2ae49dc4be8180239c5e0257cff7eb Mon Sep 17 00:00:00 2001 From: Tim Starling Date: Thu, 22 Sep 2011 03:37:39 +0000 Subject: [PATCH] Removed the redundant wfMkdirParents() call added to BitmapHandler::doTransform() in r79845. This causes problems on Wikimedia due to incorrect NFS access. If a sysadmin misconfigures their thumbnail destination directory, they should get a helpful error message, it shouldn't transparently fall back to client-side scaling and cache the resulting HTML forever. --- includes/media/Bitmap.php | 7 ------- 1 file changed, 7 deletions(-) diff --git a/includes/media/Bitmap.php b/includes/media/Bitmap.php index 24f0dbd0c5..00d6dc28af 100644 --- a/includes/media/Bitmap.php +++ b/includes/media/Bitmap.php @@ -223,13 +223,6 @@ class BitmapHandler extends ImageHandler { } else { $scaler = 'client'; } - - if ( $scaler != 'client' && $dstPath ) { - if ( !wfMkdirParents( dirname( $dstPath ), null, __METHOD__ ) ) { - # Unable to create a path for the thumbnail - return 'client'; - } - } return $scaler; } -- 2.20.1